Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=252108
--- Comment #40 from Rahul Sundaram metherid@gmail.com 2011-07-12 17:34:08 EDT ---
This is unusual
Provides: %{modulename} = %{version}
It bloats the metadata. Is it necessary? consider removing
in %install stage, rm -rf $RPM_BUILD_ROOT is redundant.
Add Build Requires on python-devel and RPM would pick up the requires automatically. You can remove the explicit requires.
%files can be reduced to
%doc examples README %{python_sitelib}/%{modulename}
Ideally, upstream should update README to explicitly mention the license and you must contact upstream to ask them to include a copy of the license. Fix these and I will get you approved