https://bugzilla.redhat.com/show_bug.cgi?id=2160996
--- Comment #11 from Luya Tshimbalanga luya_tfz@thefinalzone.net --- (In reply to Arthur Bols from comment #10)
Thanks for the changes!
- I noticed you've added this macro. Does this do anything? The only
reference I could find was a closed PR.
%global __cmake_builder ninja
It looks like that macro does nothing so I removed it.
- As Ben pointed earlier, it would be best to remove the docs/assets directory, as it contains precompiled CSS and JavaScript.
Done.
(In reply to Luya Tshimbalanga from comment #8)
The linked guideline failed to clarify about the proper use of "help2man" command in the spec file. I commented out these line for the time until a proper solution occurs.
You can use it like this:
mkdir -p %{buildroot}%{_mandir}/man1 help2man -N -o %{buildroot}%{_mandir}/man1/%{name}_decoder.1%{buildroot}/%{_bindir}/%{name}_decoder help2man -N -o %{buildroot}%{_mandir}/man1/%{name}_encoder.1 %{buildroot}/%{_bindir}/%{name}_encoder
*snip* %{_mandir}/man1/%{name}_decoder.1* %{_mandir}/man1/%{name}_encoder.1*
I hit an issue with rpmlint with the following result: rpmlint /var/lib/mock/fedora-37-x86_64/result/*.rpm ============================ rpmlint session starts ============================ rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 31, packages: 5
draco.x86_64: W: no-manual-page-for-binary draco_decoder-1.5.5 draco.x86_64: W: no-manual-page-for-binary draco_encoder-1.5.5 draco-devel.x86_64: W: no-documentation 5 packages and 0 specfiles checked; 0 errors, 3 warnings, 0 badness; has taken
How to properely implement the help2man for the case above? I vainly tried
help2man -N -o %{buildroot}%{_mandir}/man5/%{name}_decoder.1-%{version} \ --no-discard-stderr %{buildroot}/%{_bindir}/%{name}_decoder-%{version} help2man -N -o %{buildroot}%{_mandir}/man5/%{name}_encoder.1-%{version} \ --no-discard-stderr %{buildroot}/%{_bindir}/%{name}_encoder-%{version}
- missing %check Please check if it is feasible to compile and run the tests
%ctest applied on %check line.
Sadly this doesn't work:
+ /usr/bin/ctest --test-dir redhat-linux-build --output-on-failure--force-new-ctest-process -j8 Internal ctest changing into directory: /builddir/build/BUILD/draco-1.5.5/redhat-linux-build Test project /builddir/build/BUILD/draco-1.5.5/redhat-linux-build No tests were found!!!
Hm, in that condition, running the test is unfeasible in the current state it is temporarily disabled for the time being.