Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: gnome-do - quick object search and interaction Alias: gnome-do
https://bugzilla.redhat.com/show_bug.cgi?id=382371
peter@thecodergeek.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+
------- Additional Comments From peter@thecodergeek.com 2007-11-17 14:30 EST ------- Review: gnome-do 0.0.2-2
Okay, the update successfully builds in Mock (devel, x86_64 and i386). rpmlint only has a few minor complaints:
gnome-do.x86_64: E: no-binary gnome-do.x86_64: E: only-non-binary-in-usr-lib
These are ignorable, since it's a Mono package and it doesn't ship native code, but still needs to use the per-arch lib(64) directories, and has only a small wrapper script in /usr/bin.
gnome-do.x86_64: W: no-documentation gnome-do-devel.x86_64: W: no-documentation
These are because your package has no %doc files. Unfortunately, there are no reasonable files in the tarball that would be appropriate here. Thus, this is acceptable; but *please* bug upstream about including some files here: at the very least, a copy of the license text and perhaps an AUTHORS or MAINTAINERS file.
=== GOOD === + Builds in mock (Devel, x86_64 and i386). + Included source tarball matches that of upstream: 4a5287dd85d920771e9c9c086b532a51 gnome-do_0.0.2-srpm.orig.tar.gz 4a5287dd85d920771e9c9c086b532a51 gnome-do_0.0.2-upstream.orig.tar.gz + All necessary BuildRequires are listed, with no duplicates. + Final file/directory ownership is good; no duplicates are listed. + File/directory permissions are OK; proper %defattr is used. + Final requires/provides are OK. Provides: mono(Do) = 1.0.2877.19873 mono(Do.Addins) = 1.0.2877.19872 mono(Do.DBus) = 1.0.2877.19872 gnome-do = 0.0.2-2.fc8
Requires: /bin/sh mono(Do.Addins) = 1.0.2877.19872 mono(Do.DBus) = 1.0.2877.19872 mono(Mono.Cairo) = 2.0.0.0 mono(System) = 2.0.0.0 mono(gconf-sharp) = 2.16.0.0 mono(gdk-sharp) = 2.10.0.0 mono(gtk-sharp) = 2.10.0.0 mono(mscorlib) = 2.0.0.0 mono(pango-sharp) = 2.10.0.0 mono-core rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 rpmlib(VersionedDependencies) <= 3.0.3-1
+ When built, the application runs fine with no apparent bugs or segfaults/etc.
All blockers have been fixed, so gnome-do 0.0.2-2 is APPROVED.