https://bugzilla.redhat.com/show_bug.cgi?id=1699487
--- Comment #2 from Christoph Junghans junghans@votca.org --- (In reply to Robert-André Mauchin from comment #1)
- Not used:
BuildRoot: %{_tmppath}/%{name}-%{version}-build
Removed
- Missing isa:
Requires: %{name}%{?_isa} = %{version}-%{release}
Added
- mkdir -p %{buildroot}/usr/share/cmake/kim-api
→
mkdir -p %{buildroot}%{_datadir}/cmake/kim-api
Changed
- Own %{_libexecdir}/kim-api
%dir %{_libexecdir}/kim-api
Added
- In onder to avoid unirtentional soname bumps, globbing the major soname
version is now forbidden, be more specific instead:
%{_libdir}/libkim-api.so.*
Added, %global sover
- use %global, not %define
Changed
[!]: Package requires other packages for directories it uses. Note: No known owner of /usr/libexec/kim-api
Fixed.
[!]: Buildroot is not present Note: Invalid buildroot found: %{_tmppath}/%{name}-%{version}-build See: https://docs.fedoraproject.org/en-US/packaging-guidelines/
Fixed.
[!]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in kim-api , kim-api-devel , kim-api-examples
Fixed
[!]: Spec use %global instead of %define unless justified. Note: %define requiring justification: %define compdir %(pkg-config --variable=completionsdir bash-completion), %define compdir "/etc/bash_completion.d"
Fixed
Spec URL: https://junghans.fedorapeople.org/kim-api.spec SRPM URL: https://junghans.fedorapeople.org/kim-api-2.0.2-2.fc31.src.rpm TaskID: https://koji.fedoraproject.org/koji/taskinfo?taskID=34155946