Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: hydrogen - Advanced drum machine
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=190040
------- Additional Comments From green@redhat.com 2006-07-02 21:41 EST ------- (In reply to comment #8)
NEEDSWORK:
Source0 should be a full URL. It should be http://dl.sf.net/sourceforge/hydrogen/hydrogen-0.9.3.tar.gz
I've updated this to the easynews link.
You have a lingering buildreq on portaudio-devel.
Fixed.
I would recommend disabling OSS support. (%configure --disable-oss-support) AFAIK OSS has been deprecated for some time now.
Fixed.
I don't think you need all that QTDIR stuff. It seems to build just fine without it. Mock sources profile.d properly.
I think all that stuff is a good idea in order to ensure a reproducable build outside of mock.
I don't think you need to update the icon cache, its not installing any into /usr/share/icons
Fixed.
Don't need ldconfig, its not installing systemwide libraries.
Fixed.
The update-desktop-database doesn't match what's in ScriptletSnippets, and according to ScriptletSnippets, you only need it if there's a MimeType key.
Fixed (it does have a MimeType key).
Here are the updated bits:
Spec URL: http://people.redhat.com/green/FE/FC5/hydrogen.spec SRPM URL: http://people.redhat.com/green/FE/FC5/hydrogen-0.9.3-5.src.rpm