https://bugzilla.redhat.com/show_bug.cgi?id=1324204
--- Comment #3 from Petr Ĺ abata psabata@redhat.com --- What is your FAS username? You didn't include it in the request.
As for the review, I'll just start from the top.
* Your package is noarch, therefore defining the first three macros is fairly pointless. You're not getting any debuginfo for your shell script anyway. You can drop these.
* A cosmetic detail: consider expanding the tabs and aligning all the values.
* Another cosmetic detail: remove all trailing whitespace.
* Summary should begin with a capital letter.
* It's unclear whether the license is really `GPLv3' or `GPLv3+'. Since you are also the upstream -- if you're sure you really want `GPLv3', consider noting that in the README file.
* The source tarball included in the SRPM differs from the one available on GitHub (!).
* A split (and ordered) list of runtime dependencies would be more readable. For example: Requires: curl Requires: dnsmasq-utils ...
* I'm not going to comment your your runtime dependencies yet. Provide an updated package with sources available upstream first.
* Your package has no %changelog entries. Add one. "Initial release" would do.