Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=668243
--- Comment #17 from Ian Weller ian@ianweller.org 2011-02-07 21:17:35 EST --- (In reply to comment #16)
(In reply to comment #15)
- Did you make sure that there were no dependencies on other headers in the
devel subpackage? The devel subpackage only requires pkgconfig.
I believe so, we don't need std headers & man do we? Is here a way of checking? I have done rpmlint and koji builds without problems.
Well, the reason is so that when you use these header files in code, the compiler doesn't throw an error because an #include file couldn't be found.
I ran the following (very very hacky) shell script from /usr/include in an extracted version of the RPM:
for j in $(for i in $(grep -r '#include <' . | \ sed -e 's/.*#include <(.*)>$/\1/'); do find /usr/include | \ grep $i; done | less); do rpm -qf $j; done | grep -v kernel-headers | \ grep -v libstdc++-devel | grep -v glibc-headers
(kernel-headers and glibc-headers are both deps for gcc; libstdc++-devel is a dep for gcc-g++, so those don't need to be included.)
Nothing showed up in the output of that script, so I guess you're good.
- Do you have any other pending package reviews, or have you done any informal reviews of other packages?
Nope, just this one.
If you have something else you need to package, I would recommend submitting that for review and having me take a look at it. My sponsoring you depends on how well I feel you understand the Fedora packaging guidelines. I think you've got a pretty good grasp on them, but I generally like to see more than one package from any submitter. (Alternatively, you can take any package review, do an informal review of it, and link to that bug here.)