https://bugzilla.redhat.com/show_bug.cgi?id=2121759
Steve Traylen steve.traylen@cern.ch changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(steve.traylen@cer | |n.ch) |
--- Comment #3 from Steve Traylen steve.traylen@cern.ch --- New packages.
Everything addressed I believe except for the build test requirements. Comments below.
Spec URL: http://straylen.web.cern.ch/straylen/rpms/python-reactivex/python-reactivex.... SRPM URL: http://straylen.web.cern.ch/straylen/rpms/python-reactivex/python-reactivex-...
- The linked spec file looks like it is an older version - The changelog entry is for 1.32.0, but the version field and package is for 4.0.4
spec file and changelog both updated.
- The LICENSE file should be packaged with %license
Explicit reference to LICENSE file now added.
- py3_check_import should be pyproject_check_import since that is the latest suggested macro
Corrected to pyproject macro
- Something looks off with the packages installer, no version in dist info: /usr/lib/python3.11/site-packages/reactivex-0.0.0.dist-info/ This also seems to provide provides of "python3.11dist(reactivex) = 0"
Okay seems the github tag release is not complete with no version number. I switched to using the PyPi source now with just the tests from git tag. Seems to have done the job.
- The description in the srpm spec talks like this is the client for InfluxDB instead of ReactiveX ;)
Yep - corrected.
- Ideally the pytest build time req should be present in pyproject.toml so that it can be picked up by the build-time dependency generator:
https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#Automatica...
There is a pyproject section "[tool.poetry.dev-dependencies]" that contains pytest. I do not seem to be able to activate this section with "%generate_buildrequires -x dev" or something?
Have left it as is.