Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: publican-fedora - Fedora Publishing Theme
https://bugzilla.redhat.com/show_bug.cgi?id=427482
------- Additional Comments From petersen@redhat.com 2008-02-13 03:50 EST ------- Here is the review:
+:ok, =:needs attention
MUST Items: [=] MUST: rpmlint must be run on every package.
publican-fedora.src:17: W: unversioned-explicit-obsoletes documentation-devel-Fedora publican-fedora.noarch: W: obsolete-not-provided documentation-devel-Fedora
These are ok.
publican-fedora.noarch: W: incoherent-version-in-changelog 0.8-1 0.8-2
Please take care of this one.
[+] MUST: The package must be named according to the Package Naming Guidelines. [+] MUST: The spec file name must match the base package %{name}, in the format %{name}.spec unless your package has an exemption on Package Naming Guidelines.
[=] MUST: The package must meet the Packaging Guidelines.
Please remove the redundant Requires(post) and Requires(postun).
[+] MUST: The package must be licensed with a Fedora approved license and meet the Licensing Guidelines. [+] MUST: The License field in the package spec file must match the actual license. [+] MUST: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package must be included in %doc.
(But please consider Karsten's comments above.)
[+] MUST: The spec file must be written in American English. [+] MUST: The spec file for the package MUST be legible. [+] MUST: The sources used to build the package must match the upstream source
f0d61bc6d241c57e03c91f40120c0e87 package-review/publican-fedora/publican-fedora-0.8.tgz
[+] MUST: The package must successfully compile and build into binary rpms on at least one supported architecture. [+] MUST: All build dependencies must be listed in BuildRequires [+] MUST: A package must own all directories that it creates. [+] MUST: A package must not contain any duplicate files in the %files listing. [+] MUST: Permissions on files must be set properly. [+] MUST: Each package must have a %clean section, which contains rm -rf %{buildroot} (or $RPM_BUILD_ROOT). [+] MUST: Each package must consistently use macros, as described in the macros section of Packaging Guidelines. [+] MUST: The package must contain code, or permissable content. [+] MUST: If a package includes something as %doc, it must not affect the runtime of the application. [+] MUST: Packages must not own files or directories already owned by other packages. [+] MUST: At the beginning of %install, each package MUST run rm -rf %{buildroot} (or $RPM_BUILD_ROOT). See Prepping BuildRoot For %install for details. [+] MUST: All filenames in rpm packages must be valid UTF-8.
SHOULD Items: [+] SHOULD: The reviewer should test that the package functions as described. A package should not segfault instead of running, for example.
I tested "create_book --brand fedora --name ..." and a few obvious make targets, and it seems to work ok.