https://bugzilla.redhat.com/show_bug.cgi?id=1668799
Hirotaka Wakabayashi hiwkby@yahoo.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |hiwkby@yahoo.com
--- Comment #1 from Hirotaka Wakabayashi hiwkby@yahoo.com --- Hello, this is an unofficial review. Please read this for your reference.
Summary =======
1. rpmlint results 2. Koji scratch build failed
Details =======
1. rpmlint results ------------------
One warning on the source rpm and two warnings on the binary rpm, which I built after I patched jnacl.spec(I will describe the patch later). Here are the rpmlint results::
$ rpmlint /home/vagrant/rpmbuild/SRPMS/jnacl-1.0-1.fc29.src.rpm jnacl.src: W: invalid-license BSD 2.0 1 packages and 0 specfiles checked; 0 errors, 1 warnings.
$ rpmlint /home/vagrant/rpmbuild/RPMS/noarch/jnacl-1.0-1.fc29.noarch.rpm jnacl.noarch: W: incoherent-version-in-changelog 1.4.0-1 ['1.0-1.fc29', '1.0-1'] jnacl.noarch: W: invalid-license BSD 2.0 1 packages and 0 specfiles checked; 0 errors, 2 warnings.
My review on the results above is as followings.
1.1. jnacl.src: W: invalid-license BSD 2.0 "BSD 2.0" should be "BSD" if upstream license is "The BSD 2-Clause License". Here is a list of good licenses for Fedora. https://fedoraproject.org/wiki/Licensing:Main#Good_Licenses
1.2. jnacl.noarch: W: incoherent-version-in-changelog 1.4.0-1 ['1.0-1.fc29', '1.0-1'] The "1.4.0-1" entry in the changelog should be '1.0-1' if upstream release version is 1.0. See Versioning Guidelines for details. https://docs.fedoraproject.org/en-US/packaging-guidelines/Versioning/
2. Koji scratch build failed ----------------------------
Here is the result of "koji build --scratch rawhide jnacl-1.0-1.fc30.src.rpm" https://koji.fedoraproject.org/koji/taskinfo?taskID=32738169
Here is the reference to run a koji scratch build. https://fedoraproject.org/wiki/Using_the_Koji_build_system#Scratch_Builds
I think "maven-source-plugin" should be added as a BuildRequires::
*** jnacl.spec.orig 2019-02-11 12:15:11.259987034 +0000 --- jnacl.spec 2019-02-11 12:40:52.521192759 +0000 *************** *** 12,17 **** --- 12,18 ---- BuildArch: noarch
BuildRequires: maven-local + BuildRequires: mvn(org.apache.maven.plugins:maven-source-plugin) BuildRequires: mvn(biz.aQute.bnd:bnd-maven-plugin) BuildRequires: mvn(org.testng:testng) BuildRequires: junit
Here is the Koji scratch build result of the package the above patch applied. https://koji.fedoraproject.org/koji/taskinfo?taskID=32737169
Thanks in advance, Hirotaka Wakabayashi