Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: luma - A graphical tool for managing LDAP servers
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=200139
------- Additional Comments From ville.skytta@iki.fi 2006-07-25 16:34 EST ------- For reference, here's my local package of this: http://cachalot.mine.nu/5/SRPMS/luma-2.3-0.1.src.rpm
The above contains some improvements over your package but it is pretty much untested and known to be not quite complete, so approach with care. And I don't have use for luma at the moment, so I'm not doing a full review. But a quick peek into the specfile differences tells me that:
- Possibly missing Requires on python-ldap, PyQt, maybe python-smbpasswd
- Odd placement of icon and icon caches not updated (does the menu entry actually show an icon?), see my specfile for ideas for a more thorough implementation
- Could %lang'ify translations, see my specfile
- Specfile comment says "Desktop entry for nvidia-settings"