Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=475661
Nicolas Mailhot nicolas.mailhot@laposte.net changed:
What |Removed |Added ---------------------------------------------------------------------------- Summary|Review Request: |Review Request: |google-droid-fonts - The |google-droid-fonts - |Droid font set |General-purpose fonts | |released by Google as part | |of Android Flag| |fedora-cvs?
--- Comment #2 from Nicolas Mailhot nicolas.mailhot@laposte.net 2009-01-14 16:53:36 EDT --- (In reply to comment #1)
I poked around this package for 2 hours now. I couldn't find any blockers. There are two minor things I think I should say:
- Not a blocker but, as I say in all my reviews, I prefer using
%defattr(-,root,root,-)
For fonts an explicit defattr is part of the guidelines since there is no reason to have fonts with strange permissions installed :p
- All fonts (including sans-serif ones) say that they are "Serif" as (OS/2)
PFM-Family in fontforge. I think upstream needs notified.
Missed this, nice to know, will do
Other than these two, you might want to wait for the subpackage naming decision of FESCO for http://fedoraproject.org/wiki/PackagingDrafts/Font_package_naming_(2009-01-1...)
Since the changes FPC requested didn't affect srpm naming, I'll do the cvs request now.
This package (google-droid-fonts) is APPROVED by oget
Thank you!
New Package CVS Request ======================= Package Name: google-droid-fonts Short Description: General-purpose fonts released by Google as part of Android Owners: nim Branches: F-9 F-10 InitialCC: fonts-sig