Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: gnome-hearts - Game of Hearts implementation for gnome
https://bugzilla.redhat.com/show_bug.cgi?id=291741
------- Additional Comments From richip@richip.dhs.org 2007-11-25 17:25 EST ------- (In reply to comment #38)
- License seems GPLv2+
I'm no license expert so I'll take your word for it. How can one tell?
- Please add
DESTDIR="install -p"
to "make install" to keep timestamps on installed files. While there are some cases in which this method doesn't work, this method usually works for recent Makefiles.
I'm not sure how this works. Do you mean to replace 'DESTDIR=$RPM_BUILD_ROOT' with 'DESTDIR="install -p"'? Or did you mean something like 'INSTALL="install -p"'? When I tried that, it seemed to work and it seemed like make picked up that environment variable.
I'll assume that for now and released:
http://richip.dhs.org/~richip/gnome-hearts-0.2-5.svn163.fc8.src.rpm