Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: gnome-hearts - Hearts game for GNOME
https://bugzilla.redhat.com/show_bug.cgi?id=435572
mtasaka@ioa.s.u-tokyo.ac.jp changed:
What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|nobody@fedoraproject.org |mtasaka@ioa.s.u-tokyo.ac.jp Status|NEW |ASSIGNED Flag| |fedora-review?
------- Additional Comments From mtasaka@ioa.s.u-tokyo.ac.jp 2008-03-03 09:20 EST ------- For 0.2.1-1:
* License - Please change the license tag to "GPLv2+ aned GFDL". * Document files under %{_datadir}/gnome/help/ are licensed under GFDL. * The rest parts are licensed under GPLv2+
* Documents - "COPYING" file is rather mandatory for %doc if it exists.
* desktop-file-install - Please call desktop-file-install for installing desktop file.
* Timestamps - I recommend to use ------------------------------------------------------ make install DESTDIR=$RPM_BUILD_ROOT INSTALL="install -p" ------------------------------------------------------ to keep timestamps on installed files. This method usually works for recent autotool-based Makefiles.