Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: gnome-hearts - Game of Hearts implementation for gnome
https://bugzilla.redhat.com/show_bug.cgi?id=291741
------- Additional Comments From caillon@redhat.com 2007-11-23 08:07 EST ------- (In reply to comment #30)
If you haven't guessed by now, the reason "configure" doesn't exist is that I'm pulling the source from SVN. I thought of generating configure myself before archiving the source tree, but I just assumed that going through the whole autoconf thing was the better route as I was afraid there might be something on my platform that was specific to it and that autoconf on the build machine would do differently. That's 'cause I don't really know how autoconf works, ;).
To give you some idea as to why... the reason configure scripts typically aren't shipped in the repository are because they are generated from other files. So you'd have to make a change to the configure.ac or .in file, and then have to re-generate configure, and then commit that to the repository as well. Some projects that want to ship configure will have a bot watch for changes to the relevant files and regenerate and re-commit, such as Mozilla. But generally it's much easier to just deal with it when creating a tarball. This means if you're creating the tarball, the responsibility is sort of yours. ;-)
Since you are installing a .desktop file, you must register it with the system using desktop-file-install
I was wondering at what else I needed to do during install and uninstallation. Unfortunately, the Packaging Guidline doesn't go too deeply into platform-, subsystem-, or DE-specific processes. Things like "desktop-file-install" or "export GCONF_DISABLE_MAKEFILE_SCHEMA_INSTALL=1", I only glean from examples. (Or did I miss it in the Guidelines?)
http://fedoraproject.org/wiki/Packaging/Guidelines?highlight=%28Guidelines%2...
I guess I don't see any gconf stuff in the guidelines, but it doesn't look like gnome-hearts ships any gconf schemas yet (unless I'm missing them) so you don't have to worry about it.
Since you are installing langpacks, you need to make proper use of the %find_lang macro (and properly in the header of %files)
Right. Sorry about that. I actually came across that guideline but only applied it to the second package I was preparing (gpass). I'll work on it. Is that not a check that can be added to rpmlint?
Might be! Consider filing a bug against rpmlint?