Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: trousers - The open-source TCG software stack
https://bugzilla.redhat.com/show_bug.cgi?id=323441
------- Additional Comments From mtasaka@ioa.s.u-tokyo.ac.jp 2007-12-13 00:31 EST ------- Well, for 0.3.1-2:
? License related issue - build.log says that * the two binaries ps_convert and ps_inspect are created, but they are not installed. ------------------------------------------------- 891 creating ps_convert 892 creating ps_inspect 893 make[1]: Leaving directory `/builddir/build/BUILD/trousers-0.3.1/tools' 894 make[1]: Entering directory `/builddir/build/BUILD/trousers-0.3.1' 895 make[1]: Nothing to be done for `all-am'. 896 make[1]: Leaving directory `/builddir/build/BUILD/trousers-0.3.1' 897 + exit 0 ------------------------------------------------- Is this okay? ! If these two binaries are not needed, it is okay. If needed, it is legally problematic.
! Patch name - Please rename the name of the patch for us to understand what the patch is for easily.
* Timestamps - Please use -------------------------------------------------- make install DESTDIR=${RPM_BUILD_ROOT} INSTALL="install -p" -------------------------------------------------- to keep timestamps on installed files. While sometimes this does not work, this ususally works for most recent Makefiles.
* Again %clean section - Please remove "[ "${RPM_BUILD_ROOT}" != "/" ] && [ -d ${RPM_BUILD_ROOT} ] && " again. i.e. Leave only "rm -rf ${RPM_BUILD_ROOT}"
* scriptlets - What is the below part in %post for? --------------------------------------------------- if [ $? == 0 ]; then /sbin/chkconfig --level 35 tcsd on fi --------------------------------------------------- On %post $1 is not be 0 (check the section "Syntax" in http://fedoraproject.org/wiki/Packaging/ScriptletSnippets ) And actually this part is not needed as service should not be activated by default.
* Documents - I think the following files can be added to %doc. ------------------------------------------------- ChangeLog --------------------------------------------------
(In reply to comment #27)
I don't see any blocking issues, but I wonder if there is a use for the trousers-static rpm that gets built? I know static libraries need to be packaged separately, but I was wondering if there were any users of these static libraries or if they could be omitted?
- Generally static archives should be removed. If you don't think this is not needed, please remove static archives completely.