Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: R-Matrix - R module, Classes etc. for dense and sparse matrices and matrix ops
https://bugzilla.redhat.com/show_bug.cgi?id=241052
------- Additional Comments From tcallawa@redhat.com 2008-01-31 14:31 EST ------- Only items I see:
* Your changelog says you're at -4, but you forgot to increment release to 4. Just make sure that your %changelog matches. :)
Good:
- rpmlint checks return: R-Matrix.x86_64: W: incoherent-version-in-changelog 0.999375-4 0.999375-1.fc9 R-Matrix.x86_64: W: one-line-command-in-%post /usr/lib/rpm/R-make-search-index.sh R-Matrix.x86_64: W: one-line-command-in-%postun /usr/lib/rpm/R-make-search-index.sh R-Matrix-devel.x86_64: W: no-documentation No blockers there, just be careful with matching n-v-r and changelog.
- package meets naming guidelines - package meets packaging guidelines - license (GPLv2+) OK, text in %doc, matches source (explanation in spec) - spec file legible, in am. english - source matches upstream - package compiles on devel (x86_64) - no missing BR - no unnecessary BR - no locales - not relocatable - owns all directories that it creates - no duplicate files - permissions ok - %clean ok - macro use consistent - code, not content - no need for -docs - nothing in %doc affects runtime - no need for .desktop file - devel package ok - no .la files - devel requires base package n-v-r
APPROVED (just fix the release before committing).
Get your account here, and follow the rest of the steps: http://fedoraproject.org/wiki/PackageMaintainers/Join#head-a601c13b0950a8956...