Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=469743
Parag AN(पराग) panemade@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |panemade@gmail.com AssignedTo|nobody@fedoraproject.org |panemade@gmail.com Flag| |fedora-review+
--- Comment #1 from Parag AN(पराग) panemade@gmail.com 2008-11-04 05:39:28 EDT --- Review: + package builds in mock (rawhide i386). koji Build => http://koji.fedoraproject.org/koji/taskinfo?taskID=916894 + rpmlint is silent for SRPM and for RPM. + source files match upstream url a2e0d8019cf8ca3ea33d970d93f9853e IO-TieCombine-1.000.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + make test gave All tests successful. Files=1, Tests=5, 0 wallclock secs ( 0.02 usr 0.00 sys + 0.04 cusr 0.01 csys = 0.07 CPU) + Package perl-IO-TieCombine-1.000-1.fc10 => Provides: perl(IO::TieCombine) = 1.000 perl(IO::TieCombine::Handle) = 1.000 perl(IO::TieCombine::Scalar) = 1.000 Requires: perl(Carp) perl(IO::TieCombine::Handle) perl(IO::TieCombine::Scalar) perl(Symbol) perl(strict) perl(warnings)
APPROVED.