Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Merge Review: junit
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225954
tbento@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |tbento@redhat.com
------- Additional Comments From tbento@redhat.com 2007-02-09 16:58 EST ------- Here are a list to my changes:
- I changed the License to CPL, because the Packaging Guidelines states that we should use standard abbreviations and rpmlint generated a warning stating that "Common Public License" was not recognized.
- I changed the Group to Development/Tools/Java from Development/Testing, as was suggested by Tom.
- I switched the source back to junit3.8-2.zip because someone was misinformed and had removed all the binaries.
- I removed "-rm -rf $RPM_BUILD_ROOT" from the %prep section because rpmlint generated a warning stating that $RPM_BUILD_ROOT should not be touched in the prep stage because it will break short circuiting .
- I added "-rm -rf $RPM_BUILD_ROOT" to the %install section because rpmlint generated an error stating that we should clean $RPM_BUILD_ROOT this section.
- The %post and %postun sections for demo were removed because they were causing an error while building.
- I had to "escape" the macros used in the %changelog because macros are expanded in the %changelog section.
- The --excludes were added to aot-compile-rpm to solve a building error.
If someone could kindly review this, that would be great. Thanks. Tania