https://bugzilla.redhat.com/show_bug.cgi?id=1835958
--- Comment #2 from Carlos Mogas da Silva r3pek@r3pek.org --- Hi Artur!
Thanks for taking time to review this package.
(In reply to Artur Iwicki from comment #1)
spec and srpm are uploading in copr:r3pek/OpenRGB
You *need* to provide direct links to the spec and the srpm.
Oops. Sorry about that :-/
Updated versions: spec: https://download.copr.fedorainfracloud.org/results/r3pek/OpenRGB/fedora-31-x... srpm: https://download.copr.fedorainfracloud.org/results/r3pek/OpenRGB/fedora-31-x...
That being said, after digging out the spec from copr:
%global debug_package %{nil}
This disables generating debug packages, which is generally a no-no in Fedora. Try removing this line and building the package again. If it fails, you'll need to dig around and figure out how to build the program with debuginfo enabled. https://docs.fedoraproject.org/en-US/packaging-guidelines/ #_debuginfo_packages
Cleaned that up and built fine with mockbuild
BuildRequires: libusb-devel libstdc++-devel qt5-qtbase-devel desktop-file-utils
You need to add a BuildRequires: on "gcc-c++". While it's installed by default in the copr buildroot, this is *not* the case for koji (i.e. the builder for official Fedora packages).
Good info ;) thx
mkdir -p %{buildroot}/%{_bindir} install -Dpm 755 %{_name} \ %{buildroot}%{_bindir}/%{_name}
Passing -D to install makes it create directories as needed along the way, so either remove the -D flag and keep "mkdir -p" above (though arguably it'd be better to use "install -d"), or keep the -D flag and remove the unnecessary mkdir call.
Cleaned it up (kept the -D and removed mkdir)
#doc mkdir -p %{buildroot}%{_defaultdocdir}/%{_name} install -Dpm 644 README.md \ %{buildroot}%{_defaultdocdir}/%{_name}/README.md
Instead of copying the readme during %install, just use the "%doc" marker inside the %files section (it works basically the same as %license).
Nice! haven't read about %doc. Using it now
%files %{_datadir}/icons/hicolor/128x128/%{_name}.png
This necessitates a Requires: on "hicolor-icon-theme".
Added
Also, looking at the upstream repository:
- dependencies/
- ColorWheel
- NVFC
- hidapi
- inpout32_1501
- libe131/src
- libusb-1.0.22
hidapi and libusb are available in Fedora as separate packages, so it'd be highly recommended to remove those bundled dependencies and build the program against the system-provided libraries.
Yeah. the libusb one is actually just used in the Windows version of the app, but upstream was using bundled hidapi on linux too. I just made a patch that builds the package with the system libhidapi-libusb (and will try go get fixed upstream)