https://bugzilla.redhat.com/show_bug.cgi?id=2316537
Luya Tshimbalanga luya_tfz@thefinalzone.net changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+
--- Comment #15 from Luya Tshimbalanga luya_tfz@thefinalzone.net --- (In reply to Tom.Rix from comment #12)
Spec URL: https://trix.fedorapeople.org/hiprt.spec SRPM URL: https://trix.fedorapeople.org/hiprt-2.4-1.6b6daf9.fc42.src.rpm
For the addition of clang, which i believe is a false positive. clang comes from comgr-devel -> clang-devel -> clang
Yes, it is indeed a false positive upon verification. Maybe filing a bug report to rpmlint to resolve that particular issue. Back to the review, one small details is to add a comment for each patch according to https://docs.fedoraproject.org/en-US/packaging-guidelines/PatchUpstreamStatu... preferably after importing the source rpm. However, based on the criteria adhering to the packaging guideline, this package is ready for submission in the repository.
APPROVED!