Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: fwbackups - a user backup program, with support for automated backups and on-demand backups
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=205075
------- Additional Comments From tibbs@math.uh.edu 2006-09-25 23:42 EST ------- Hmm, the tarball does not match upstream:
c987096dc11e2605f4a73c19484a4a9b fwbackups-1.42.tar.gz 10c8fda1c5809681aa870a2c71f84ed5 ../fwbackups-1.42.tar.gz
The files are different sizes as well (31347 in the srpm, 32282 upstream).
I'm not sure why you have constructs like this in %install: install -p -d -m755 etc/fwbackups\ ${RPM_BUILD_ROOT}%{_sysconfdir}/fwbackups
install -d creates each of its arguments as directories, but "etc/fwbackups" already exists because it's in your source tarball.
You install fwbackups.conf twice.
I think you could significantly shrink your %install section with by using "cp -rp" instead of installing each file separately, but I suppose that's up to you.
Note that there's currently some discussion about changing the recommendations for installing desktop files, but that won't be decided for another several days and I don't think it will effect your package.
Are you sure fwbackups.conf.default should go in /etc? It should certainly not be marked noreplace as you want it to change on an upgrade (since the old version isn't the default any longer). I would consider marking it %doc instead.