[Bug 1372866] Review Request: hyperscan - Hyperscan is a high-performance multiple regex matching library

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1372866

--- Comment #9 from gil cattaneo  ---
(In reply to Ralf Corsepius from comment #8)
> MUSTFIXES:
> Package does not honor RPM_OPT_FLAGS:
>
> Your spec appends Fedora incompatible compilation flags to CFLAGS/CXXFLAGS.
>
> Remove these 2 lines from your spec:
> export CFLAGS="$RPM_OPT_FLAGS -march=core2"
> export CXXFLAGS="${CFLAGS}"
> Directory /usr/include/hs/ is unowned.
>
> Add this directory to *-devel's %files
> Package ships static libs.
>
> This is strongly discouraged in Fedora. Please disable building static libs
> unless there are very strong reasons to ship them.
> The base package contains files which should be packaged in *-devel,
>
> instead of the base package.
> %{_libdir}/*.so should go into devel,
> %{_libdir}/*.so.* into <base>

I agree