https://bugzilla.redhat.com/show_bug.cgi?id=1979275
Zbigniew Jędrzejewski-Szmek zbyszek@in.waw.pl changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |POST Assignee|nobody@fedoraproject.org |zbyszek@in.waw.pl Flags| |fedora-review+
--- Comment #7 from Zbigniew Jędrzejewski-Szmek zbyszek@in.waw.pl ---
And flake8 already has a complex requires on the others:
(python3.10dist(mccabe) < 0.7 with python3.10dist(mccabe) >= 0.6) (python3.10dist(pycodestyle) < 2.8 with python3.10dist(pycodestyle) >= 2.7) (python3.10dist(pyflakes) < 2.4 with python3.10dist(pyflakes) >= 2.3)
I does, but apparently those requirements are not enough: the builds failed in tests when done in the "wrong" order.
I do not see any build failures for python-lsp-jsonrpc. Here is a build after pycodestyle, etc. were updated - https://koji.fedoraproject.org/koji/taskinfo?taskID=71417694
Hmm, the builds still fail in mock for me. Doesn't matter, I used this mock build for review instead.
+ package name is OK + license is acceptable for Fedora (MIT) + license is specified correctly + builds and installs OK + BR/R/P look OK (*) + rpmlint shows nothing
In general it's the modern packaging template, so there isn't much to review… All the things that Miro pointed out above get a +1 from me. Please consider implementing them when importing.
Package is APPROVED.
(*) I see "python3dist(python-lsp-jsonrpc)" in the autogenerated Provides. I would expect "python3dist(lsp-jsonrpc)". Not sure what to make of this.