https://bugzilla.redhat.com/show_bug.cgi?id=2324911
--- Comment #11 from Peter Lemenkov lemenkov@gmail.com --- (In reply to Benson Muite from comment #10)
Comments: a) To ensure directory ownership, please add Requires: hicolor-icon-theme
Done.
b) Please validate the appdata file, see https://docs.fedoraproject.org/en-US/packaging-guidelines/AppData/ #_app_data_validate_usage add BuildRequires: libappstream-glib appstream-util validate-relax --nonet %{buildroot}%{_metainfodir}/*.metainfo.xml
Done.
c) Please use the %find_lang for translation files, see: https://docs.fedoraproject.org/en-US/packaging-guidelines/ #handling_locale_files
...
d) Ideally translation files should be in %{_datadir}/locale/a%{locale}/LC_MESSAGES/%{name}.mo
My need patches for https://github.com/ihhub/fheroes2/blob/master/src/fheroes2/system/settings. cpp#L525 https://github.com/ihhub/fheroes2/blob/master/CMakeLists.txt#L87-L96 Not sure if a blocker though, coupled to point c.
Yeah, a way of dealing with locale data in this game engine is not entirely standard. I'll try to convince upstream to move them into common directories (```/usr/share/locale```). Meanwhile maybe it's better to keep it as is?
e) Can a man page be generated: https://github.com/ihhub/fheroes2/blob/master/docs/fheroes2.6.in
Done. Thanks for pointing me out! I was not aware of this one.
f) Maybe add a smoke test fheros2 --version
Requires display and working keyboard and mice.
g) Does the license file https://github.com/ihhub/fheroes2/blob/master/files/soundfonts/GeneralUser- GS-LICENSE.txt also need to be indicated?
I don't think so - it is a requirement for Windows installer. We have working SDL_Mixer and we're good.
h) Is there a license for https://github.com/ihhub/fheroes2/blob/master/files/data/resurrection.h2d
I guess the same GPLv2 since it was added in this PR:
* https://github.com/ihhub/fheroes2/pull/3828/ * https://github.com/ihhub/fheroes2/pull/3828/commits/a8e84e32f307f858e171b4bb...
I asked upstream about the status of this particular data artifact - https://github.com/ihhub/fheroes2/issues/9267.
New package, the same links:
Spec URL: https://peter.fedorapeople.org/packages/fheroes2.spec SRPM URL: https://peter.fedorapeople.org/packages/fheroes2-1.1.3-1.fc41.src.rpm
Koji scratch build for Rawhide:
* https://koji.fedoraproject.org/koji/taskinfo?taskID=125746117