https://bugzilla.redhat.com/show_bug.cgi?id=2327650
Fabio Valentini decathorpe@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED
--- Comment #6 from Fabio Valentini decathorpe@gmail.com --- I would prefer if you did not use sed to patch Cargo.toml.
It makes it really hard to debug ("did this sed actually do anything?") and makes it hard for other people to contribute to the package. Though I think there is a mode for sed that makes it fail if the expression doesn't match any line in the file? Using this would make this at least a bit better.
This is not a package for a "crate" so you don't necessarily need to re-generate the spec file with rust2rpm for every version, and most Cargo.toml patches won't affect the generated spec file. So if you make sed calls that don't make any changes fail, I think that would be "ok" (though I would still prefer using a patchset, similar to what we do in ruff, uv, or maturin).