[Bug 728701] Review Request: libalkimia - Financial library

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=728701

--- Comment #2 from Kalev Lember  2011-08-20 03:01:51 EDT ---
Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=3288505
failed, looks like the package is missing BuildRequires on gmp-devel.
> %check
> ...
> test "$(pkg-config --modversion libalkimia)" = "%{version}" ||:

What's the point in having this test in %check, if you ignore the return value?
> %install
> rm -rf %{buildroot}

Just a small nit, current versions of rpmbuild automatically do this for you
and there's no need to explicitly clean buildroot in %install.