https://bugzilla.redhat.com/show_bug.cgi?id=1288870
Yanis Guenane yguenane@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |yguenane@redhat.com
--- Comment #5 from Yanis Guenane yguenane@redhat.com --- My review is yet unofficial as I am not part of the packager group.
I have three remarks one the spec file.
1. Can you condition the py3 related actions (subpackages, build, install, %files) ? This way we can use the same spec file on Fedora with python3 support, and EL7 with no python3 support.
Using something like the following :
%if 0%{?fedora} %global with_python3 1 %endif
%if 0%{?with_python3} %py3_build %endif
2. Upstream provides several files that should go in a %doc in the %files section but they are not currently listed. I am thinking about
* changelog.md * readme.md * release-notes.md
3. Upstream provides a way to generate a complete documentation[1], a -doc subpackage might be a good idea to provide it for the end user.
[1] https://github.com/pymc-devs/pymc3/blob/master/howto_docs.md