[Bug 591190] Review Request: debhelper - Helper programs for debian/rules

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=591190

--- Comment #19 from Ralf Corsepius  2012-03-28 11:30:54 EDT ---
(In reply to comment #18)
> Added BuildRequires: perl-Test-Harness (used by 'make test')
> Also need perl-Test-More (which is not in Fedora yet)

Both changes are wrong.

* You should not require perl-<module> but use BR: perl(<module>), instead.

* perl(Test::More) is part of Fedora for ages.
  BR: perl(Test::More).
> So we run 'make test', but ignore the results

Why? We should not ignore the test results.