Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=525796
Guido Grazioli guido.grazioli@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+
--- Comment #6 from Guido Grazioli guido.grazioli@gmail.com 2009-10-02 20:23:32 EDT --- I get this one on my system building rpms: /usr/lib/gcc/x86_64-redhat-linux/4.4.1/../../../../lib64/libgtkhotkey.so: undefined reference to `gdk_x11_window_get_drawable_impl' so i searched for that function and it happened to be included in gtk 2.17.11 (it seems to be gtkhotkey related, but gtkhotkey itself was built successfully here).
However if it builds in koji i'm happy with that.
Please note i noticed that in the libgtkhotkey package, you still need to add the *explicit* Requires: pkgconfig to the -devel package (and only there). Consider adding it on next update.
Addendum to the review above:
OK - The package MUST successfully compile and build http://koji.fedoraproject.org/koji/taskinfo?taskID=1724728
OK - rpmlint output 3 packages and 1 specfiles checked; 0 errors, 0 warnings.
Package APPROVED.