Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: bouncycastle
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=197963
jkeating@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |NEEDINFO_REPORTER AssignedTo|notting@redhat.com |jkeating@redhat.com OtherBugsDependingO|188265 |188267 nThis| |
------- Additional Comments From jkeating@redhat.com 2006-07-10 16:50 EST ------- NEEDSWORK: - Buildroot should be %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n) - Remove Epoch: 0 - Specifying 0 epoch on Requires and BuildRequires is not necessary. Remove them. - RPM_BUILD_ROOT=bctmp aot-compile-rpm <-- what is this doing? Why reset the buildroot? - Post and postun scripts should probably have logic for final removal vs upgrade. As it stands you'll run rebuild-security-providers and rebuild-gcj-db twice every time you upgrade the package. Once for the new package, and once for removing the old package.
rpmlint output:
E: bouncycastle zero-length /etc/java/security/security.d/2000-org.bouncycastle.jce.provider.BouncyCastleProvider W: bouncycastle-debuginfo objdump-failed objdump: /tmp/bouncycastle-debuginfo-1.33-1.x86_64.rpm.17761/usr/lib/debug/usr/lib64/gcj/bouncycastle/bcprov-1.33.jar.so.debug: File format not recognized W: bouncycastle mixed-use-of-spaces-and-tabs W: bouncycastle non-conffile-in-etc /etc/java/security/security.d/2000-org.bouncycastle.jce.provider.BouncyCastleProvider W: bouncycastle objdump-failed objdump: /tmp/bouncycastle-1.33-1.x86_64.rpm.17761/usr/lib64/gcj/bouncycastle/bcprov-1.33.jar.so: File format not recognized
The Zero length file, I see it just being touched. Does it just need to exist? If so, we can ignore the error. However it should be marked as a config file.
Not sure about the objdump warnings.