https://bugzilla.redhat.com/show_bug.cgi?id=2358970
Fabio Valentini decathorpe@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |POST Flags|fedora-review? |fedora-review+
--- Comment #18 from Fabio Valentini decathorpe@gmail.com --- Hm, this looks good, with one potential exception - I think the fact that the tests/main.rs file is now excluded but still referenced in the Cargo.toml file might break things when building this crate as a dependency of something else, but I'm not sure. You might need to change the %exclude from tests/ to tests/data and tests/snapshots then. But you can cross that bridge when you get to it.
As for excluding the "derive" feature - fair enough, if you don't need it and it would involve packaging more dependencies, then this is a perfectly fine solution.
===
Package was generated with rust2rpm, simplifying the review.
✅ package contains only permissible content ✅ package builds and installs without errors on rawhide ✅ test suite is run and all unit tests pass ✅ latest version of the crate is packaged ✅ license matches upstream specification and is acceptable for Fedora ✅ license files are included with %license in %files ✅ package complies with Rust Packaging Guidelines
Package APPROVED.
===
Recommended post-import rust-sig tasks:
- set up package on release-monitoring.org: project: $crate homepage: https://crates.io/crates/$crate backend: crates.io version scheme: semantic version filter (*NOT* pre-release filter): alpha;beta;rc;pre distro: Fedora Package: rust-$crate
- set bugzilla assignee overrides to @rust-sig (optional)