https://bugzilla.redhat.com/show_bug.cgi?id=1795053
dan.cermak@cgc-instruments.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |dan.cermak@cgc-instruments. | |com
--- Comment #1 from dan.cermak@cgc-instruments.com --- Overall this looks good, I have the following questions/comments:
- please don't put plain macros into comments, that's just asking for trouble with m4, prevent their expansion via %% or replace the # with %dnl (will only work in Rawhide & F32 though) - upstream has a test suite, consider running it in %check? - you have added 3 sed calls into %prep: * please add an explanation why you have added these and what they do * You unrestrict the pycurl dependency: given that you don't run any tests, this seems a bit dangerous, especially given this oddly specific version requirement (and that we have a newer version in Rawhide). If you believe that the dependency specification is wrong, then please submit a patch upstream and patch the sources in the spec. - The documentation is not built, why? If there is an upstream issue, please link to it.