Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=479903
Michael Schwendt bugs.michael@gmx.net changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |bugs.michael@gmx.net
--- Comment #14 from Michael Schwendt bugs.michael@gmx.net 2009-01-27 08:52:33 EDT --- The original %files section was fine:
%{_datadir}/gdesklets/Controls/ImageSlideShow/ %{_datadir}/gdesklets/Displays/SlideShow/
Why did you change it...?
%dir %{_datadir}/gdesklets/Controls/%{_ctrlname} %dir %{_datadir}/gdesklets/Displays/%{_appname} %{_datadir}/gdesklets/Controls/%{_ctrlname}/* %{_datadir}/gdesklets/Displays/%{_appname}/*
Both are equivalent.
%setup -q -n %{_appname} tar -xf %{SOURCE1} -C ../
The way the two tarballs are extracted is strange. Sure, you can do it like that, but having to deal with the "../" in subsequent commands decreases the readability of the spec file. I strongly encourage you to use
%setup -q -c %{name}-%{version} -a1
to extract both tarballs into the same root directory, and then either use your two macros %_appname and %_ctrlname when accessing files or entering directories.
The LICENSE, MANIFEST, README and "todo" files are installed in addition to %doc, and it is important to note that the LICENSE file must not be removed from /usr/share/gdesklets/Displays/SlideShow/LICENSE - or else it cannot be displayed by the desklet.
Opening "Configure desklet" and selecting a folder from which to load images always displays an error dialog:
| The folder contents could not be displayed | | Operation not supported
It seems it always starts in the root directory due to that.