https://bugzilla.redhat.com/show_bug.cgi?id=1074129
--- Comment #4 from Petr Pisar ppisar@redhat.com --- Spec file changes:
--- perl-Compress-LZF.spec.old 2014-03-08 06:27:17.000000000 +0100 +++ perl-Compress-LZF.spec 2014-03-12 11:00:35.000000000 +0100 @@ -7,6 +7,7 @@ Group: Development/Libraries URL: http://search.cpan.org/dist/Compress-LZF/ Source0: http://www.cpan.org/modules/by-module/Compress/Compress-LZF-%%7Bversion%7D.t... +Patch1: compress_lzf_unbundle.patch BuildRequires: perl BuildRequires: perl(DynaLoader) BuildRequires: perl(Exporter) @@ -15,16 +16,13 @@ Requires: perl(:MODULE_COMPAT_%(eval "`%{__perl} -V:version`"; echo $version))
%description -LZF is an extremely fast (not that much slower than a pure memcpy) -compression algorithm. It is ideal for applications where you want to save -some space but not at the cost of speed. It is ideal for repetitive data as -well. The module is self-contained and very small (no large library to be -pulled in). It is also free, so there should be no problems incorporating -this module into commercial programs. +This is Perl binding to the LZF compression library
%prep %setup -q -n Compress-LZF-%{version}
+%patch1 + %build %{__perl} Makefile.PL INSTALLDIRS=vendor OPTIMIZE="$RPM_OPT_FLAGS" make %{?_smp_mflags}
TODO: The description is non-descriptive.
TODO: Append full-stop mark at the end of the %description.
FIX: Bundled LZF sources (lzf_c.c, lzfP.h, lzf_c_best.c) are licensed under (BSD or GPLv2+). This must be declared in the License tag too. Or unbundle the code.
FIX: You forgot to mention the lzf_c_best.c license in the License tag (because you still use it).
FIX: Unbundle the LZF library (lzf_c.c, lzfP.h, lzf_c_best.c) and use system implementation (liblzf). Or obtain exception from Fedora Packaging Committee https://fedoraproject.org/wiki/Packaging:No_Bundled_Libraries.
FIX: Build-require liblzf-devel.
TODO: I strongly recommend to delete the unbundled files in %prep section to make sure they will not be used for building.
FIX: You kept files (lzf_c_best.c) that come from libzf development sources (http://cvs.schmorp.de/liblzf/) and its dependency lzfP.h. This is still considered as a bundling. The best approach is to ask liblzf developers and maintainers to do a new release with these files. Otherwise you need to obtain exception from FPC. Alternatively you can remove support for the "best compression level" from LZF.xs.
Please correct all `FIX' items, and provide new spec file. Resolution: Package NOT approved.