Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Merge Review: xrestop
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226657
kevin@tummy.com changed:
What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|kevin@tummy.com |sandmann@redhat.com Flag|fedora-review? |fedora-review-
------- Additional Comments From kevin@tummy.com 2007-02-04 10:01 EST -------
OK - Package meets naming and packaging guidelines OK - Spec file matches base package name. OK - Spec has consistant macro usage. OK - Meets Packaging Guidelines. OK - License (GPL) OK - License field in spec matches OK - License file included in package OK - Spec in American English OK - Spec is legible. OK - Sources match upstream md5sum: 5ff774ff9cbb5997f0fb68e712dee302 xrestop-0.2.tar.gz 5ff774ff9cbb5997f0fb68e712dee302 xrestop-0.2.tar.gz.1 OK - BuildRequires correct OK - Package has %defattr and permissions on files is good. OK - Package has a correct %clean section. See below - Package has correct buildroot OK - Package is code or permissible content. OK - Packages %doc files don't affect runtime.
OK - Package compiles and builds on at least one arch. OK - Package has no duplicate files in %files. OK - Package doesn't own any directories other packages own. OK - Package owns all the directories it creates. See below - No rpmlint output. OK - final provides and requires are sane:
SHOULD Items:
OK - Should build in mock. OK - Should build on all supported archs OK - Should function as described. See below - Should have dist tag See below - Should package latest version 0 outstanding bugs - check for outstanding bugs on package.
Issues:
1. Buildroot should be the standard one.
2. rpmlint says: E: xrestop zero-length /usr/share/doc/xrestop-0.2/NEWS
Drop the NEWS file? Also the INSTALL file is the generic autotools one, and should also be dropped.
3. Should use the dist tag?
4. The latest version is 0.4 upstream. I think you can then also drop the man patch as this is fixed upstream.
5. There's some odd # SUBDIRS= comments that should get removed...