https://bugzilla.redhat.com/show_bug.cgi?id=2235080
Sandro <gui1ty(a)penguinpee.nl> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
Flags| |fedora-review?
Doc Type|--- |If docs needed, set a value
Assignee|nobody(a)fedoraproject.org |gui1ty(a)penguinpee.nl
CC| |gui1ty(a)penguinpee.nl
--- Comment #1 from Sandro <gui1ty(a)penguinpee.nl> ---
Looking at the spec file:
%global pypi_name pymaven-patch
%global pypi_name_with_underscore %(echo "%{pypi_name}" | sed
"s/-/_/g")
%global github_name pymaven
This seems over engineered. Here you could really benefit from the forge
macros. I'll supply a patch for inspiration.
You are not using all the macros consistently (e.g.: `%pyproject_save_files
pymaven`). Personally, I'd do away with the macros and just spell it out. Makes
the spec file easier to read.
A comment on why `export PBR_VERSION=%{version}` is needed would be
appreciated. It helps others understanding the spec file.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2235080
Report this comment as SPAM:
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=rep...