https://bugzilla.redhat.com/show_bug.cgi?id=825409
Sébastien Boisvert seb@boisvert.info changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |seb@boisvert.info
--- Comment #4 from Sébastien Boisvert seb@boisvert.info --- This is an informal review as I am not sponsored yet.
Patch0: %{name}-1.2.2-fedora.patch Patch1: %{name}-1.0.1-playerdir.patch BuildRequires: boost-devel BuildRequires: cegui-devel
Add a new line between the Patch1 line and the first BuildRequires line.
%description devel The %{name}-devel package contains libraries and header files for developing applications that use %{name}
Add a '.' at the end of the description.
%package playerplugin
Maybe name that player-plugin ?
See http://fedoraproject.org/wiki/Packaging:NamingGuidelines#Separators
rm -rf $RPM_BUILD_ROOT
You must stick to macros. Use %{buildroot}. See http://fedoraproject.org/wiki/Packaging:Guidelines#Using_.25.7Bbuildroot.7D_...
%global abiversion 1.2
How tightly coupled is the ABI version to the upstream version ?
Spec URL: http://rmattes.fedorapeople.org/RPMS/gazebo/gazebo.spec
$ rpmlint -i gazebo.spec gazebo.spec: W: patch-not-applied Patch1: %{name}-1.0.1-playerdir.patch A patch is included in your package but was not applied. Refer to the patches documentation to see what's wrong.
0 packages and 1 specfiles checked; 0 errors, 1 warnings.
SRPM URL: http://rmattes.fedorapeople.org/RPMS/gazebo/gazebo-1.2.5-1.fc17.src.rpm
I can not find some dependencies. Are they under review ? If so, can you provide the buzilla entries ? Or are they in rpmfusion ?
$ pwd /home/seb/rpmbuild/SPECS
$ rpmbuild -ba gazebo.spec error: Failed build dependencies: console-bridge-devel is needed by gazebo-1.2.5-1.fc17.x86_64 libccd-devel is needed by gazebo-1.2.5-1.fc17.x86_64 urdfdom-headers-devel is needed by gazebo-1.2.5-1.fc17.x86_64 urdfdom-devel is needed by gazebo-1.2.5-1.fc17.x86_64
[root@panic SPECS]# yum install -y console-bridge-devel libccd-devel urdfdom-headers-devel urdfdom-devel Loaded plugins: langpacks, presto, refresh-packagekit No package console-bridge-devel available. No package libccd-devel available. No package urdfdom-headers-devel available. No package urdfdom-devel available. Error: Nothing to do