Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: xgridfit - Font hinting tool
https://bugzilla.redhat.com/show_bug.cgi?id=437052
panemade@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+
------- Additional Comments From panemade@gmail.com 2008-03-12 06:58 EST ------- Review: + package builds in mock (rawhide i386). koji build => http://koji.fedoraproject.org/koji/taskinfo?taskID=512207 + rpmlint is silent for SRPM and for RPM. + source files match upstream. 78a322021939e81cb3e2a04a306ed60b xgridfit-1-5.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc files present in -doc subpackage. + BuildRequires are proper. + defattr usage is correct. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code. + no static libraries. + no .pc file present. + no -devel subpackage exists. + no .la files. + no translations are available. + Does owns the directories it creates. + no duplicates in %files. + file permissions are appropriate. + no scriptlets are used. + Not a GUI app.
Also, you should change Group for -doc to Documentation as given at http://fedoraproject.org/wiki/Packaging/Guidelines#head-9bbfa57478f0460c6160...
APPROVED.