[Bug 1262552] Review Request: python-pyhsm - Python module to talk to YubiHSM hardware

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1262552

--- Comment #4 from Zbigniew Jędrzejewski-Szmek  ---
- license is OK
- license file is present, %license is used
- new python macros are used (mostly)
- rpmlint:

2 packages and 0 specfiles checked; 0 errors, 0 warnings.

- provides:
python-pyhsm = 1.0.4l-2.fc24

Please generate python2-pyhsm binary subpackage, and add
%{?python_provide:%python_provide python2-%{srcname}}.

- requires:
/bin/sh
/usr/bin/env
/usr/bin/python
python(abi) = 2.7
rpmlib(CompressedFileNames) <= 3.0.4-1
rpmlib(FileDigests) <= 4.6.0-1
rpmlib(PartialHardlinkSets) <= 4.0.4-1
rpmlib(PayloadFilesHavePrefix) <= 4.0-1
rpmlib(PayloadIsXz) <= 5.2-1

OK, except that /usr/bin/env is suspicious.

run.sh in Tests/ is completely broken. Should be either fixed or removed.

Some files in /bin/ use #!/usr/bin/env python, others use #!/usr/bin/python.
Please fix them all to use #!%{__python2}.