Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=604500
Parag AN(पराग) panemade@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |panemade@gmail.com AssignedTo|nobody@fedoraproject.org |panemade@gmail.com Flag| |fedora-review+
--- Comment #3 from Parag AN(पराग) panemade@gmail.com 2010-06-21 05:08:04 EDT --- Review: + package builds in mock (rawhide i686). koji Build =>http://koji.fedoraproject.org/koji/taskinfo?taskID=2261364 + rpmlint is silent for SRPM and for RPM. + source files match upstream url (sha1sum) fa51b69bd89a53e821b30002287c62eadcaccb66 ibus-input-pad-0.1.0.20100611.tar.gz fa51b69bd89a53e821b30002287c62eadcaccb66 ibus-input-pad-0.1.0.20100611.tar.gz.srpm
+ package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + license is open source-compatible. + License text is included in package. + %doc is present. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + Not a GUI application
Suggestions: 1) %description should be The input-pad engine for IBus platform.
2) Like all other ibus-* engines in Fedora, this should Requires: ibus
3) you don't need following BuildRequires: pkgconfig
See a successful koji build http://koji.fedoraproject.org/koji/taskinfo?taskID=2261603 without it.
APPROVED.