Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=469291
Tom "spot" Callaway tcallawa@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |tcallawa@redhat.com AssignedTo|nobody@fedoraproject.org |tcallawa@redhat.com Flag| |fedora-review?
--- Comment #13 from Tom "spot" Callaway tcallawa@redhat.com 2009-02-27 10:35:33 EDT --- %define ver 20070815
Please don't do this. Just put that in Version: and use %{version}. It will simplify the spec.
Also, the license tag is wrong. All of the code simply says "GPL", so the tag should be : License: GPL+
See: http://fedoraproject.org/wiki/Licensing/FAQ#How_do_I_figure_out_what_version...
Also, it looks like the Source0 url is wrong, it should be:
http://user-mode-linux.sourceforge.net/%%7Bname%7D_%%7Bversion%7D.tar.bz2
And... ncurses-devel is a Requires of readline-devel, so you shouldn't need to BuildRequires it.
Aside from that, everything looks fine. I'll finish the review, but please show me a finished package before I can flip the approved flag.
== Review == Good:
- rpmlint checks return: uml_utilities.x86_64: E: setuid-binary /usr/bin/uml_net root 04755 uml_utilities.x86_64: E: non-standard-executable-perm /usr/bin/uml_net 04755 Safe to ignore. - package meets naming guidelines - package meets packaging guidelines - license (GPL+) OK, text in %doc, matches source - spec file legible, in am. english - source matches upstream (4e10de8e0f5bf681fa295572009518b77fd8a1dd) - package compiles on devel (x86_64) - no missing BR - no unnecessary BR - no locales - not relocatable - owns all directories that it creates - no duplicate files - permissions ok - %clean ok - macro use consistent - code, not content - no need for -docs - nothing in %doc affects runtime - no need for .desktop file