Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: ocsinventory-client - Open Computer and Software Inventory Next Generation client
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=217275
------- Additional Comments From pertusus@free.fr 2006-11-28 16:13 EST ------- (In reply to comment #7)
In that case you can add a Requires on the directories, or have ocsinventory-client own those directories, until they get owned by the filesystem package.
Is this a MUST for the review ?
Yes. I make exception for /usr/share/icons/hicolor.
In the packaging guidelines it is at http://fedoraproject.org/wiki/Packaging/Guidelines#head-a5931a7372c4a0006571...
And in that case I think it is relevant, since it materializes whether you want to have a real dependency on logrotate/cron or make logrotate/cron optional - which means that the package owns the directory.
I look at some core package and don't see anything...
Most core packages haven't gone through the guidelines and lacks the fedora extras packages quality.
Some improvement to have ocsinventory-client build and work on RHEL and older FC (i really need this at work).
With EPEL, this is indeed something acceptable or even encouraged. Besides in that case it doesn't really hurt legibility.
Spec URL: http://remi.collet.free.fr/rpms/extras/ocsinventory-client.spec SRPM URL: http://remi.collet.free.fr/rpms/extras/ocsinventory-client-1.0-0.4.RC3.fc7.s...
- Tue Nov 28 2006 Remi Collet Fedora@famillecollet.com 1.0-0.4.RC3
- requires %%{_sbindir}/dmidecode (kernel-utils in FC3) rather than dmidecode
- requires perl(:MODULE_COMPAT) only on Fedora (not provided on RHEL3)
- patch improved (Fedora is RPM based)
Apart from directory owning, seems right. Notice that I didn't assign the bug to myself, so a reviewer accepting unowned directories for those directories can step up.