https://bugzilla.redhat.com/show_bug.cgi?id=1821120
Bug ID: 1821120 Summary: Review Request: wlogout - wayland based logout menu Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Assignee: nobody@fedoraproject.org Reporter: bob.hepple@gmail.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://download.copr.fedorainfracloud.org/results/wef/wlogout/fedora-31-x86... SRPM URL: https://download.copr.fedorainfracloud.org/results/wef/wlogout/fedora-31-x86...
Description: A wayland based logout menu.
Fedora Account System Username: wef
Note that fedora-review incorrectly flags the /etc/wlogout/* files as 'not configuration'. They are exactly that - configuration files.
Package Review ==============
Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed
===== MUST items =====
C/C++: [ ]: Package does not contain kernel modules. [ ]: Package contains no static executables. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Header files in -devel subpackage, if present. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs.
Generic: [ ]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [ ]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [ ]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Expat License", "*No copyright* Expat License", "Unknown or generated". 24 files have unknown license. Detailed output of licensecheck in /home/bhepple/tmp/wlogout/licensecheck.txt [ ]: License file installed when any subpackage combination is installed. [ ]: Package does not own files or directories owned by other packages. Note: Dirs in package are owned also by: /usr/share/bash- completion(flatpak, breezy, libmbim, chocolate-doom, cpu-x, clevis, kmod, python3-trezor, docopt, lightdm, ffsend, the_silver_searcher, etckeeper, darcs, buildah, devscripts-checkbashisms, sway, maven, swaylock, tio, vagrant, beaker-client, yadifa-tools, calf, source- highlight, reprepro, toolbox, filesystem, licensecheck, zeitgeist, exa, rpmlint, bash-completion, tracker, cowsay, dotnet-host, mercurial-py3, zola, restic, dnf, swayidle, lxi-tools, mtr, pdfgrep, why3, glib2, pbuilder, cmake-data, python3-catkin_tools, awscli, bubblewrap, lxc, zypper, falkon, unar, tealdeer, skim, rtags, skopeo, cobbler, fedpkg, nitrokey-app, yadifa, exercism, clufter-cli, eg, devscripts, mercurial-py2, docker-compose, nnn, git-core, ethtool, git-annex, rkt, task, plowshare, ModemManager, dconf-editor, ripgrep, policycoreutils, datamash, hstr, ldc, stratis-cli, subversion, bodhi- client, python-django-bash-completion, gammu, gpaste, rpmspectool, fd- find, rpmdevtools, fedmod, libqmi, driverctl), /usr/share/bash- completion/completions(flatpak, breezy, libmbim, chocolate-doom, cpu-x, clevis, libappstream-glib, kmod, python3-trezor, docopt, lightdm, nbdkit-bash-completion, ffsend, firewalld, the_silver_searcher, etckeeper, buildah, devscripts-checkbashisms, sway, maven, swaylock, tio, vagrant, coccinelle-bash-completion, kompose, beaker-client, yadifa-tools, calf, source-highlight, reprepro, toolbox, filesystem, licensecheck, zeitgeist, exa, rpmlint, bash-completion, tracker, cowsay, dotnet-host, mercurial-py3, zola, restic, dnf, swayidle, lxi-tools, mtr, pdfgrep, why3, glib2, pbuilder, cmake-data, ndctl, python3-catkin_tools, awscli, libguestfs-bash- completion, bubblewrap, libnbd-bash-completion, lxc, zypper, lastpass- cli, falkon, unar, tealdeer, skim, rtags, skopeo, gtatool, cobbler, fedpkg, nitrokey-app, yadifa, exercism, clufter-cli, eg, devscripts, mercurial-py2, docker-compose, nnn, git-core, ethtool, git-annex, rkt, tig, task, firejail, plowshare, opensc, ModemManager, dconf-editor, ripgrep, calibre, datamash, nordugrid-arc-hed, minipro, hstr, ldc, GMT-common, python3-pip, xss-lock, stratis-cli, subversion, bodhi- client, python-django-bash-completion, gammu, gpaste, rpmspectool, fd- find, rpmdevtools, fedmod, libqmi, driverctl), /usr/share/fish(zola, bat, flatpak, fish, ffsend, exercism, tealdeer, fd-find, cpu-x, ripgrep, task, swayidle, ocrmypdf, sway, fedmod, docker-compose, exa, swaylock), /usr/share/fish/completions(task, fish), /usr/share/zsh(pulseaudio, reprepro, ripgrep, osmium-tool, cpu-x, awscli, python3-wstool, exa, polybar, ffsend, skim, curl, zola, kde- connect, etckeeper, exercism, xss-lock, stratis-cli, libinput, swayidle, mercurial-py2, sway, docker-compose, creds, zsh, swaylock, gpaste, pdfgrep, fd-find, mako, task, vcsh, why3, fedmod, ninja-build, mercurial-py3), /usr/share/zsh/site-functions(googler, flatpak, podman, pulseaudio, reprepro, osmium-tool, cpu-x, ripgrep, awscli, python3-wstool, exa, lastpass-cli, arch-install-scripts, polybar, ffsend, khard, skim, curl, firewalld, zola, buku, kde-connect, exercism, restic, xss-lock, stratis-cli, libinput, imgp, mercurial- py2, sway, swayidle, xpanes, docker-compose, creds, nnn, zsh, swaylock, ddgr, gpaste, pdfgrep, fd-find, mako, task, vcsh, why3, fzf, kompose, ninja-build, mercurial-py3) [ ]: %build honors applicable compiler flags or justifies otherwise. [ ]: Package contains no bundled libraries without FPC exception. [ ]: Changelog in prescribed format. [ ]: Sources contain only permissible code or content. [ ]: Package contains desktop file if it is a GUI application. [ ]: Development files must be in a -devel package [ ]: Package uses nothing in %doc for runtime. [ ]: Package consistently uses macros (instead of hard-coded directory names). [ ]: Package is named according to the Package Naming Guidelines. [ ]: Package does not generate any conflict. [ ]: Package obeys FHS, except libexecdir and /usr/target. [ ]: If the package is a rename of another package, proper Obsoletes and Provides are present. [ ]: Requires correct, justified where necessary. [ ]: Spec file is legible and written in American English. [ ]: Package contains systemd file(s) if in need. [ ]: Useful -debuginfo package or justification otherwise. [ ]: Package is not known to require an ExcludeArch tag. [ ]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 1 files. [ ]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local
===== SHOULD items =====
Generic: [ ]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [ ]: Final provides and requires are sane (see attachments). [ ]: Package functions as described. [ ]: Latest version is packaged. [ ]: Package does not include license text files separate from upstream. [ ]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [ ]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [ ]: Package should compile and build into binary rpms on all supported architectures. [ ]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Fully versioned dependency in subpackages if applicable. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified.
===== EXTRA items =====
Generic: [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched.
Rpmlint ------- Checking: wlogout-1.1.1-2.fc33.x86_64.rpm wlogout-debuginfo-1.1.1-2.fc33.x86_64.rpm wlogout-debugsource-1.1.1-2.fc33.x86_64.rpm wlogout-1.1.1-2.fc33.src.rpm wlogout.x86_64: W: spelling-error Summary(en_US) logout -> lo gout, lo-gout, log out wlogout.x86_64: W: spelling-error %description -l en_US logout -> lo gout, lo-gout, log out wlogout.x86_64: W: non-conffile-in-etc /etc/wlogout/layout wlogout.x86_64: W: non-conffile-in-etc /etc/wlogout/style.css wlogout.src: W: spelling-error Summary(en_US) logout -> lo gout, lo-gout, log out wlogout.src: W: spelling-error %description -l en_US logout -> lo gout, lo-gout, log out 4 packages and 0 specfiles checked; 0 errors, 6 warnings.
Rpmlint (debuginfo) ------------------- Checking: wlogout-debuginfo-1.1.1-2.fc33.x86_64.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings.
Rpmlint (installed packages) ---------------------------- wlogout.x86_64: W: spelling-error Summary(en_US) logout -> lo gout, lo-gout, log out wlogout.x86_64: W: spelling-error %description -l en_US logout -> lo gout, lo-gout, log out wlogout.x86_64: W: invalid-url URL: https://github.com/ArtsyMacaw/wlogout <urlopen error [Errno -2] Name or service not known> wlogout.x86_64: W: non-conffile-in-etc /etc/wlogout/layout wlogout.x86_64: W: non-conffile-in-etc /etc/wlogout/style.css wlogout-debuginfo.x86_64: W: invalid-url URL: https://github.com/ArtsyMacaw/wlogout <urlopen error [Errno -2] Name or service not known> wlogout-debugsource.x86_64: W: invalid-url URL: https://github.com/ArtsyMacaw/wlogout <urlopen error [Errno -2] Name or service not known> 3 packages and 0 specfiles checked; 0 errors, 7 warnings.
Source checksums ---------------- https://github.com/ArtsyMacaw/wlogout/archive/1.1.1/wlogout-1.1.1.tar.gz : CHECKSUM(SHA256) this package : cc79c9e2ff1bd225b051a34ccb352bcf8a1991b83414a7db623fce7c49566940 CHECKSUM(SHA256) upstream package : cc79c9e2ff1bd225b051a34ccb352bcf8a1991b83414a7db623fce7c49566940
Requires -------- wlogout (rpmlib, GLIBC filtered): libc.so.6()(64bit) libgdk-3.so.0()(64bit) libglib-2.0.so.0()(64bit) libgobject-2.0.so.0()(64bit) libgtk-3.so.0()(64bit) libgtk-layer-shell.so.0()(64bit) rtld(GNU_HASH)
wlogout-debuginfo (rpmlib, GLIBC filtered):
wlogout-debugsource (rpmlib, GLIBC filtered):
Provides -------- wlogout: wlogout wlogout(x86-64)
wlogout-debuginfo: debuginfo(build-id) wlogout-debuginfo wlogout-debuginfo(x86-64)
wlogout-debugsource: wlogout-debugsource wlogout-debugsource(x86-64)
Generated by fedora-review 0.7.5 (5fa5b7e) last change: 2020-02-16 Command line :/usr/bin/fedora-review --rpm-spec -n /home/bhepple/rpmbuild/SRPMS/wlogout-1.1.1-2.fc31.src.rpm Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, C/C++, Shell-api Disabled plugins: fonts, Python, SugarActivity, PHP, Java, Haskell, R, Perl, Ocaml Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH