https://bugzilla.redhat.com/show_bug.cgi?id=2238233
Davide Cavalca davide@cavalca.name changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review+ Status|NEW |POST Assignee|nobody@fedoraproject.org |davide@cavalca.name
--- Comment #4 from Davide Cavalca davide@cavalca.name --- - Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 105225510 bytes in 2544 files. See: https://docs.fedoraproject.org/en-US/packaging- guidelines/#_documentation
[!]: Large data in /usr/share should live in a noarch subpackage if package is arched. Note: Arch-ed rpms have a total of 57600000 bytes in /usr/share libdatachannel-devel-0.19.1-1.fc40.x86_64.rpm:57579520 See:
https://fedoraproject.org/wiki/Packaging:ReviewGuidelines#Package_Review_Gui...
These should be fixed by making the appropriate subpackages. There's also a ton of rpmlint warnings as it tries to parse binary samples as text files. Not sure what the right course of action is here, but probably worth reporting to rpmlint at least. Besides this, APPROVED.