Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=455067
--- Comment #4 from Mamoru Tasaka mtasaka@ioa.s.u-tokyo.ac.jp 2008-08-24 02:20:23 EDT --- For 2.0.2-0:
* Release number - The minimum number which can be used for Release number is 1. 0 is used only for pre-release tarballs: http://fedoraproject.org/wiki/Packaging/NamingGuidelines#Package_Release (Of course, please change the Release number every time you modify your spec file)
* License - As far as I verified the source code, the license tag should be "GPLv2+".
* rpmlint issue ------------------------------------------------------ ferm.noarch: W: incoherent-version-in-changelog 2.0.2 2.0.2-0.fc10 ------------------------------------------------------ - The last entry of %changelog should contain full EVR (epoch-version-release) information like: ------------------------------------------------------ * Fri Aug 22 2008 Pavel Alexeev <Pahan [ at ] Hubbitus [ DOT ] spb [ dOt.] su> - 2.0.2-1 ------------------------------------------------------
* Macros usage consistency - When using { on macros, please use { for all macros (except for some cases) consistently. You use %{_mandir} and %_sbindir , for example.
* Documents - Please also add the following files to %doc. ------------------------------------------------------ NEWS ------------------------------------------------------
(In reply to comment #3)
(In reply to comment #2)
- "system/firewalls" is not a standard Group (please refer to $ rpmlint -I non-standard-group
Thanks. I'm change it to "Applications/System". But another question is why rpmlint was silent??
- On my system rpmlint warned about this.s
- "Requires: perl" is redundant. Usually perl (module) related dependencies are automatically detected and added to rebuilt binary rpms by rpmbuild.
I suppose that do not requires external perl modules. Requires: perl removed. But I can't understand how it will be detected? It is based on standard Makefile, nor perl buildsystem.
- This is detected by /usr/lib/rpm/perl.req. Try ------------------------------------------------------ $ rpm -ql ferm | /usr/lib/rpm/perl.req ------------------------------------------------------ For example when perl.req finds the line like: ------------------------------------------------------ use Data::Dumper; ------------------------------------------------------ (in /usr/sbin/import-ferm), rpmlint adds "Requires: perl(Data::Dumper) to binary rpms.