Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=737511
--- Comment #5 from Bohuslav Kabrda bkabrda@redhat.com 2011-09-13 05:58:04 EDT --- (In reply to comment #4)
- %doc macro in -doc sub-package
- I would suggest to mark by %doc macro only documents. It means that the
test suite and the Gemfile should not be marked as doc.
- There are also other opinions, such as that everything in -doc sub-package is documentation and there is no need to mark anything as a documentation. However I do not share this POV.
I definitelly agree, that marking tests and Gemfile as doc wasn't appropriate - fixed.
- Substantially different R and BR
- Requires and BuildRequires differ substantially, so I wonder what is the reason for the difference. I guess that ActiveRecord and ActionMailer are just optional dependencies, but I'd like to be sure.
ActiveRecord and ActionMailer are really required during tests, but I managed to remove some Requires (concretely activesupport and actionpack), which are already required by railties.
SPEC: http://bkabrda.fedorapeople.org/haml-rails/rubygem-haml-rails.spec SRPM: http://bkabrda.fedorapeople.org/haml-rails/rubygem-haml-rails-0.3.4-3.fc15.s... Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=3347929