https://bugzilla.redhat.com/show_bug.cgi?id=2260492
--- Comment #7 from Neil Hanlon neil@shrug.pw --- Skipping the formality of entire review template as there are no glaring errors or problems. That said, a few notes and comments for posterity, mostly/exclusively from rpmlint.
Expected: these are set purposefully.
``` incus.x86_64: E: non-standard-dir-perm /var/cache/incus 700 incus.x86_64: E: non-standard-dir-perm /var/lib/incus 711 incus.x86_64: E: non-standard-dir-perm /var/log/incus 700 ```
These seem possibly problematic, but I admit I am not sure if the selinux one is expected, as above.
``` incus-selinux.noarch: E: non-readable /var/lib/selinux/targeted/active/modules/200/incus 0 incus.x86_64: W: log-files-without-logrotate ['/var/log/incus'] incus.x86_64: W: post-without-tmpfile-creation /usr/lib/tmpfiles.d/incus.conf ```
Expected -- comes from macros and are standard:
``` incus-selinux.noarch: W: dangerous-command-in-%pre cp incus-selinux.noarch: W: dangerous-command-in-%postun rm incus-selinux.noarch: W: dangerous-command-in-%posttrans rm incus-selinux.noarch: W: dangerous-command-in-%post rm ```
The rest of the review looks great. Aside from these couple items/questions, this is good to go, from my perspective.
If you want to throw some answers back at me and/or address issues if you think they are in need of fixing, I'm happy to throw an Approved stamp on this.