https://bugzilla.redhat.com/show_bug.cgi?id=2020307
Arthur Bols arthur@bols.dev changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review?
--- Comment #8 from Arthur Bols arthur@bols.dev --- Again a licensing issue. :/
I'm in a hurry so here's a quick rundown of issues, but overall it looks quite good. - Add a license breakdown - Report the missing licenses upstream - Add the README.md with %doc
sed -i 's/SocialMedia/X-SocialMedia/g' %{buildroot}%{_kf5_datadir}/applications/org.kde.%{name}.desktop
You have a commit upstream to fix it. Please add it as a comment so you won't forget to remove it in the future. A patch would be better. I'm fine with it in this case, since it should be gone in the next release.
%license LICENSES/*.txt
You can remove the .txt to match all files. This would be useful if they add a license file without extension.