Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: tig - Text-mode interface for git
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=241978
------- Additional Comments From jbowes@redhat.com 2007-06-01 12:20 EST ------- (In reply to comment #5)
A few of things that I did in my spec (none of them blockers):
- Build the HTML documentation and list them in %doc. After they are built
you'll need to convert CRLF line endings to LF line endings.
Include the manual.txt in %doc.
Added -DVERSION\"%{version}-%{release}\" to the CFLAGS. That way tig
will print the rpm release when you type "tig --version". Could help with debugging down the road...
- Use %{_mandir} and %{_prefix} instead of hard-coded paths in the "make
install" line.
I went ahead and updated the spec with these, with the exception of #3. It feels kind of weird to me, but if you feel strongly about it, we can put it in later.
New locations: Spec URL: http://jbowes.dangerouslyinc.com/tmp/tig.spec SRPM URL: http://jbowes.dangerouslyinc.com/tmp/tig-0.7-3.fc7.src.rpm
Otherwise my spec and your spec are nearly identical. Feel free to list me as a co-maintainer once the package is approved.
Will do!